#85 fail-safe wrapper around BC compliance checks that access risky/throw-happy reflection API #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption is captured
…s diff analysis
…s constant diff analysis
…tion diff analysis
…rface diff analysis
…od diff analysis
…s property diff analysis
…t diff analysis
…s on risky reflection operations This effectively prevents an analysis from completely crashing, which is a relatively decent solution. The exit code will stay non-zero if a check is skipped, but the analysis will no longer clog up when something like an unresolved symbol, extension, constant or infinitely recursive resolution happens.
Ocramius
commented
Aug 21, 2018
| @@ -52,6 +54,12 @@ public static function removed(string $description, bool $isBcBreak) : self | |||
| return new self(self::REMOVED, $description, $isBcBreak); | |||
| } | |||
|
|
|||
| public static function skippedDueToFailure(Throwable $failure) : self | |||
| { | |||
| // @TODO Note: we may consider importing the full exception for better printing later on | |||
Ocramius
deleted the
feature/#85-fail-safe-wrapper-around-comparison-failures
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85