Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not reset on constructor because the pins are not set yet #50

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

mathieucarbou
Copy link
Contributor

No description provided.

@RobTillaart RobTillaart self-assigned this Jun 17, 2024
@RobTillaart RobTillaart added the bug Something isn't working label Jun 17, 2024
@RobTillaart
Copy link
Owner

Sounds like a bug...

@RobTillaart
Copy link
Owner

Yes 100% confirmed

@RobTillaart RobTillaart merged commit 1c72c6b into RobTillaart:master Jun 17, 2024
3 checks passed
@RobTillaart
Copy link
Owner

RobTillaart commented Jun 17, 2024

@mathieucarbou
Thanks for this fix, appreciated.
Will refactor the constructor (initialize variables) and release a new version today.
Also created an issue in HX711_MP as it has same bug.

RobTillaart added a commit that referenced this pull request Jun 17, 2024
RobTillaart added a commit that referenced this pull request Jun 17, 2024
RobTillaart added a commit that referenced this pull request Jun 17, 2024
RobTillaart added a commit that referenced this pull request Jun 17, 2024
- fix #50, bug in constructor (thanks Mathieu!)
  - refactor constructor
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants