-
Notifications
You must be signed in to change notification settings - Fork 1
PyOpenSci REVIEW - add setup to docs, add building docs to contributing #50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
PyOpenSci REVIEW - add setup to docs, add building docs to contributing #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Robaina, here is how we can collaborate in PRs!
Though I am not a reviewer on this one, I can submit feedback on the committed changes.
This way, we can deal with it without opening a new PR
Co-authored-by: Alex Batisse <alexandre.batisse@hey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Codecov ReportBase: 86.07% // Head: 86.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 86.07% 86.47% +0.39%
==========================================
Files 11 12 +1
Lines 826 806 -20
==========================================
- Hits 711 697 -14
+ Misses 115 109 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This PR addresses one of the comments from reviewer @Batalex in PyOpenSci:
Agreed!
Yes, that would be necessary. Will do.