Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated bower.json and readme #307

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Updated bower.json and readme #307

merged 1 commit into from
Aug 26, 2015

Conversation

alexgleason
Copy link
Contributor

  1. The readme asks us to use --save-dev which isn't useful since DropKick is a front-end dependency. --save is the right command.
  2. The path for the main file is wrong. I updated it to the correct path.
  3. The bower.json file doesn't list jQuery as a dependency. Because of that, tools which import front-end assets may include them out of order, so that DropKick is imported before jQuery. Spent some time debugging this today, see grunt-bower-concat for an example of something that uses this.
  4. version in bower.json has been deprecated.
  5. I added some more data from the package.json file into bower.json. Why not? It'll make DropKick more searchable.

Let me know if you have any question! Or if you disagree with any of my points. Thanks.

@Robdel12
Copy link
Owner

Very nice! Thanks for the PR :)

Robdel12 added a commit that referenced this pull request Aug 26, 2015
@Robdel12 Robdel12 merged commit baad532 into Robdel12:master Aug 26, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants