fix(validator): always require typing-extensions #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 96.00% 96.00% -0.01%
==========================================
Files 100 100
Lines 4082 4079 -3
Branches 263 262 -1
==========================================
- Hits 3919 3916 -3
Misses 121 121
Partials 42 42
Continue to review full report at Codecov.
|
RobertCraigie
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #114
On Python 3.9.0 and Python 3.9.1,
typing.TypedDictdoes not correctly hold the__required_keys__and__optional_keys__attributes, the fix (python/cpython#22736) for this issue was merged on 10/12/2020 and Python 3.9.1 was released on 8/12/2020, as such, the minimum Python version that does not require the use oftyping-extensionsis Python 3.9.2However, writing our imports this way breaks mypy, reporting 1651 errors :)