Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

React example #597

Merged
merged 2 commits into from
Mar 4, 2023
Merged

React example #597

merged 2 commits into from
Mar 4, 2023

Conversation

MatthijsBurgh
Copy link
Contributor

superseeds #587

@MatthijsBurgh
Copy link
Contributor Author

@snorresovold things I changed, which are good to take into account for future examples:

  • Use geometry_msgs/Pose2D instead of a custom msg
  • Be consistent with linting
  • Remove all unnecessary dependencies, code, file, etc.

@MatthijsBurgh
Copy link
Contributor Author

Preferably examples are tested in CI. But that requires to install and build it before it can be tested. Therefore not doing it.

@MatthijsBurgh MatthijsBurgh marked this pull request as ready for review March 4, 2023 08:52
@MatthijsBurgh MatthijsBurgh merged commit 9da0906 into develop Mar 4, 2023
@MatthijsBurgh MatthijsBurgh deleted the examples branch March 4, 2023 08:52
MatthijsBurgh added a commit that referenced this pull request Dec 4, 2023
@MatthijsBurgh @snorresovold
React example (#597)
d2d5c09 
* Made a simple react example

* (react-example) get it working

---------

Co-authored-by: snorresovold <snorresovold@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthijsBurgh @snorresovold