Ensure fieldType is a scalar if arrayLen is -1
#638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbell
changed the title
fieldType is a scalar if arrayLen is -1
|
@scottbell I will take a look at this, but it could take some time. |
|
@sea-bass @EzraBrooks what do you think of this PR? I see you approved the related PR in |
sea-bass
approved these changes
Nov 16, 2023
MatthijsBurgh
pushed a commit
that referenced
this pull request
Dec 4, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Before this change,
typeDefDict[fieldName]was always assigned as an array, irrespective of other variables’ states. With this new update, if thearrayLenis equal to-1, thetypeDefDict[fieldName]is assigned the non-array valuefieldType. IfarrayLendoesn't equal-1, the assignment remains an array format,[fieldType].We used this to successfully decode ROS2 nested types.
#463