Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only image topics with camera_info are being published #18

Closed
herr-biber opened this issue Dec 21, 2015 · 1 comment
Closed

Only image topics with camera_info are being published #18

herr-biber opened this issue Dec 21, 2015 · 1 comment

Comments

@herr-biber
Copy link

Is there a reason why only image topics with camera_info are being published?
See
https://github.com/RobotWebTools/web_video_server/blob/develop/src/web_video_server.cpp#L195

To me, it would make more sense to publish all image topics, regardless of camera_info, since web display does not use camera_info at all.

This also simplifies code (string juggling from camera_info topic name to image topic names.

@mitchellwills
Copy link

All image topics are actually published (available as described here http://wiki.ros.org/web_video_server#Available_URLs), but I guess just not listed. The code in question only controls which are listed on the main page. I thought that I had it setup to display all image topics (with those with a camera_info in a group and the rest individually), but looking at it again it looks like I never implemented that. I don't really have time to implement it, but if you want to submit a PR to clean this up I would take a look at it.

jihoonl added a commit that referenced this issue Nov 4, 2016
Fixed topic list to display all image topics, fixing Issue #18.
@bjsowa bjsowa closed this as completed Sep 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants