-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Spell checker improvements #340
Conversation
This pull request will make it so you can only enable 1 language at a time, or disable all together. This change significantly improves the speed of the app, in particular the windows version when typing or pasting in text. Does anyone have a need to be able to select multiple languages? |
The limitation of one language per time only exists just to prevent users to select multiple languages or it changes the implementation? Can we keep the multi language and just alert user when select more then 1 language? Multiple languages is very useful to me. Thoughts here @RocketChat/core ? |
@rodrigok The implementation has changed so that it only allows 1 at a time. If multiple languages are need then we could disable multiple languages when using Hunspell (I think it is mostly just win 7 and below that uses this). Only issue is that we would have different implementation based on operating systems. |
I have now changed it so that if it uses Hunspell then you will only be allowed one language, otherwise it will allow multiple. |
@RocketChat/core
Closes #195
Closes #263
Closes #281
Closes #289
Closes #306
TODO