Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Spell checker improvements #340

Merged
merged 6 commits into from
Feb 6, 2017
Merged

Spell checker improvements #340

merged 6 commits into from
Feb 6, 2017

Conversation

alexbrazier
Copy link
Contributor

@alexbrazier alexbrazier commented Feb 3, 2017

@RocketChat/core

Closes #195
Closes #263
Closes #281
Closes #289
Closes #306

  • Tidy up spell checker implementation
  • Fix issues with contractions
  • Fix speed issues on windows (pasting bug) - This requires limiting spell checking to one language as switching was causing the speed issues

TODO

  • Check that it is working correctly on windows

@alexbrazier alexbrazier changed the title Tidy up spell checker and fix contractions Spell checker improvements Feb 4, 2017
@alexbrazier
Copy link
Contributor Author

This pull request will make it so you can only enable 1 language at a time, or disable all together. This change significantly improves the speed of the app, in particular the windows version when typing or pasting in text.

Does anyone have a need to be able to select multiple languages?

@rodrigok
Copy link
Member

rodrigok commented Feb 4, 2017

The limitation of one language per time only exists just to prevent users to select multiple languages or it changes the implementation? Can we keep the multi language and just alert user when select more then 1 language?

Multiple languages is very useful to me.

Thoughts here @RocketChat/core ?

@alexbrazier
Copy link
Contributor Author

@rodrigok The implementation has changed so that it only allows 1 at a time.

If multiple languages are need then we could disable multiple languages when using Hunspell (I think it is mostly just win 7 and below that uses this). Only issue is that we would have different implementation based on operating systems.

@alexbrazier
Copy link
Contributor Author

I have now changed it so that if it uses Hunspell then you will only be allowed one language, otherwise it will allow multiple.

@alexbrazier alexbrazier modified the milestone: 2.4.0 Feb 5, 2017
@engelgabriel engelgabriel merged commit f5d8fb8 into develop Feb 6, 2017
@engelgabriel engelgabriel deleted the feature/spellcheck branch February 6, 2017 19:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants