Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Filter hidden rooms from share extension #2092

Conversation

Sameesunkaria
Copy link
Collaborator

@RocketChat/ios

Closes #2091

@codecov
Copy link

codecov bot commented Jul 28, 2018

Codecov Report

Merging #2092 into develop will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2092      +/-   ##
===========================================
+ Coverage    36.08%   36.37%   +0.29%     
===========================================
  Files          374      374              
  Lines        17496    17496              
===========================================
+ Hits          6313     6364      +51     
+ Misses       11183    11132      -51
Impacted Files Coverage Δ
Rocket.Chat/API/Clients/PushClient.swift 0% <0%> (-33.34%) ⬇️
...Chat/Managers/Socket/Response/SocketHandlers.swift 38.63% <0%> (-25%) ⬇️
...at/Controllers/Base/BaseNavigationController.swift 42.5% <0%> (-12.5%) ⬇️
...at/Controllers/Auth/AuthNavigationController.swift 32.2% <0%> (-10.17%) ⬇️
...et.Chat/Managers/Socket/Response/SocketError.swift 93.33% <0%> (-6.67%) ⬇️
...ket.Chat/Controllers/Base/BaseViewController.swift 80.48% <0%> (-4.88%) ⬇️
...Managers/Model/AuthManager/AuthManagerSocket.swift 23.07% <0%> (-4.49%) ⬇️
Rocket.Chat/Managers/AppManager.swift 62.61% <0%> (-0.47%) ⬇️
...hat/Controllers/Base/MainSplitViewController.swift 85.18% <0%> (ø) ⬆️
...ubscriptionsList/SubscriptionsViewController.swift 38.96% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d7535...498fabf. Read the comment docs.

@@ -42,7 +42,7 @@ struct SEState {
let displayedRooms: [Subscription]
switch searchRooms {
case .none:
displayedRooms = rooms
displayedRooms = rooms.filter { $0.open }
case .searching(let search):
let search = search.lowercased()
displayedRooms = rooms.filter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the case .started:? Do we need to add it here too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, yeah.

@rafaelks rafaelks merged commit 7720ad4 into RocketChat:develop Jul 30, 2018
@rafaelks rafaelks added this to the 3.1.0 milestone Jul 31, 2018
@Sameesunkaria Sameesunkaria deleted the 2091-filter-hidden-rooms-share-extension branch August 31, 2018 12:03
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants