This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[CHORE] Use latest swift for all pods #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sameesunkaria
changed the title
rafaelks
reviewed
Sep 4, 2018
Podfile
Outdated
| installer.pods_project.targets.each do |target| | ||
| target.build_configurations.each do |config| | ||
| config.build_settings['SWIFT_VERSION'] = '3.1' | ||
| config.build_settings['SWIFT_VERSION'] = '4.1' |
There was a problem hiding this comment.
4.2 to support Xcode 10 already @Sameesunkaria? :-)
There was a problem hiding this comment.
Umm, it may take some time for the dependencies to update to the latest version of swift. There are some changes in UIKit introduced with Swift 4.2, so it's probably better for us to keep it at 4.1.
We can easily change it to 4.2 down the line.
Sameesunkaria
changed the title
|
Looks good @Sameesunkaria, thank you! :-) |
rafaelks
approved these changes
Sep 6, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Use Swift 4.1 for all pods by default, except for those which require swift 3 support.