Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[TESTS][CI] Fixing the timeout problem we have on tests when CI is busy #2214

Merged
merged 8 commits into from
Sep 28, 2018

Conversation

rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Sep 27, 2018

@RocketChat/ios

  • Fixed all the timeout issues we had when running tests by changing how Realm works during tests;
  • Removed all usage of expectations & dispatches with delays because of Realm;
  • Included our Pods in the project repository to avoid downloading it again on CI every time;
  • Updated CONTRIBUTING guide to remove all CocoaPods references;
  • Reduced total CI time in about 7 minutes (24 minutes to 17 minutes);

Before

screen shot 2018-09-27 at 15 11 45

After

screen shot 2018-09-27 at 15 29 21

@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@6156052). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2214   +/-   ##
==========================================
  Coverage           ?   29.79%           
==========================================
  Files              ?      383           
  Lines              ?    14435           
  Branches           ?        0           
==========================================
  Hits               ?     4301           
  Misses             ?    10134           
  Partials           ?        0
Impacted Files Coverage Δ
Pods/FirebaseCore/Firebase/Core/FIRLogger.m 63.04% <ø> (ø)
Pods/FirebaseCore/Firebase/Core/FIRComponentType.m 0% <ø> (ø)
Pods/FirebaseCore/Firebase/Core/FIRDependency.m 0% <ø> (ø)
...baseCore/Firebase/Core/FIRAnalyticsConfiguration.m 0% <ø> (ø)
Pods/FirebaseCore/Firebase/Core/FIRComponent.m 0% <ø> (ø)
Pods/FirebaseCore/Firebase/Core/FIRConfiguration.m 0% <ø> (ø)
Pods/FirebaseCore/Firebase/Core/FIROptions.m 0% <ø> (ø)
...FirebaseCore/Firebase/Core/FIRComponentContainer.m 0% <ø> (ø)
...Core/Firebase/Core/FIRAppAssociationRegistration.m 0% <ø> (ø)
Pods/FirebaseCore/Firebase/Core/FIRBundleUtil.m 0% <ø> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6156052...cca063e. Read the comment docs.

@rafaelks rafaelks added this to the 3.2.0 milestone Sep 27, 2018
@rafaelks rafaelks changed the title [TESTS][WIP] Fixing the timeout problem we have on tests when CI is busy [TESTS][CI] Fixing the timeout problem we have on tests when CI is busy Sep 27, 2018
Copy link
Collaborator

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great! Thanks for this change @rafaelks, it will help a lot to avoid false positives and keep tests OK 💯

@rafaelks rafaelks merged commit 021b758 into develop Sep 28, 2018
@rafaelks rafaelks deleted the chore/fix_unit_tests_timing branch September 28, 2018 13:37
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants