Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Support sending messages with new composer #2223

Merged

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented Sep 28, 2018

@RocketChat/ios

@@ -1,6 +1,6 @@
source 'https://github.com/CocoaPods/Specs.git'

platform :ios, '10.0'
platform :ios, '11.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@@ -5735,7 +5731,7 @@
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = S6UPZG7ZR3;
INFOPLIST_FILE = Rocket.Chat/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@@ -5596,7 +5592,7 @@
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = S6UPZG7ZR3;
INFOPLIST_FILE = Rocket.Chat/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@@ -5571,7 +5567,7 @@
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = S6UPZG7ZR3;
INFOPLIST_FILE = Rocket.Chat/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@@ -5376,7 +5372,7 @@
DEVELOPMENT_TEAM = S6UPZG7ZR3;
GCC_OPTIMIZATION_LEVEL = s;
INFOPLIST_FILE = Rocket.Chat/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! 👏

@rafaelks rafaelks added this to the 3.2.0 milestone Sep 28, 2018
@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #2223 into feature/integrate-rc-view-controller will decrease coverage by 0.05%.
The diff coverage is 5.55%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##           feature/integrate-rc-view-controller   #2223      +/-   ##
=======================================================================
- Coverage                                 27.95%   27.9%   -0.06%     
=======================================================================
  Files                                       400     400              
  Lines                                     14953   14989      +36     
=======================================================================
+ Hits                                       4180    4182       +2     
- Misses                                    10773   10807      +34
Impacted Files Coverage Δ
.../Chat/MessagesViewControllerComposerDelegate.swift 0% <0%> (ø)
...cket.Chat/Controllers/Chat/MessagesViewModel.swift 54.23% <0%> (-9.77%) ⬇️
...ket.Chat/Controllers/Chat/ChatViewController.swift 0% <0%> (ø) ⬆️
...Chat/Controllers/Chat/MessagesViewController.swift 48.71% <100%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5ece4...4e92427. Read the comment docs.

@rafaelks rafaelks merged commit 6f4e5bc into feature/integrate-rc-view-controller Sep 29, 2018
@rafaelks rafaelks deleted the feat/integrate_composer branch September 29, 2018 01:10
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants