[CHORE] Update RocketChatViewController to reflect latest fixes #2293
Conversation
| @@ -435,3 +443,4 @@ extension RocketChatViewController { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
File Line Length Violation: File should contain 400 lines or less: currently contains 446 (file_length)
Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)
| strongSelf.internalData = newData | ||
| UIView.performWithoutAnimation { | ||
| let changeset = StagedChangeset(source: source, target: target) | ||
| collectionView.reload(using: changeset, interrupt: { $0.changeCount > 100 }) { newData, changes in |
There was a problem hiding this comment.
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument. (multiple_closures_with_trailing_closure)
rafaelks
force-pushed
the
chore/update_rocketchatviewcontroller_sdk
branch
from
41f1afc to
2d70a65
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2293 +/- ##
========================================
Coverage 25.96% 25.96%
========================================
Files 432 432
Lines 15857 15857
========================================
Hits 4118 4118
Misses 11739 11739Continue to review full report at Codecov.
|
@RocketChat/ios
This update includes fixes for invalid indexPaths and small code improvements.