Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Reintroduce message drafting #2308

Merged
merged 4 commits into from
Nov 13, 2018
Merged

[FIX] Reintroduce message drafting #2308

merged 4 commits into from
Nov 13, 2018

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented Nov 12, 2018

@RocketChat/ios

Also moved some extensions to other files to keep MessageViewController.swift under 400 lines.

Closes #2302

@cardoso cardoso added this to the 3.2.0 milestone Nov 12, 2018
@cardoso cardoso self-assigned this Nov 12, 2018
@cardoso cardoso requested a review from rafaelks November 12, 2018 18:06
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #2308 into develop will increase coverage by 0.25%.
The diff coverage is 39.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2308      +/-   ##
===========================================
+ Coverage    26.02%   26.27%   +0.25%     
===========================================
  Files          433      436       +3     
  Lines        15875    15918      +43     
===========================================
+ Hits          4132     4183      +51     
+ Misses       11743    11735       -8
Impacted Files Coverage Δ
...ntrollers/Chat/MessagesViewControllerSending.swift 0% <0%> (ø) ⬆️
...Chat/Controllers/Chat/MessagesViewController.swift 33.51% <100%> (-0.33%) ⬇️
...rollers/Chat/MessageViewControllerEmptyState.swift 19.04% <19.04%> (ø)
...trollers/Chat/MessageViewControllerSearching.swift 36.36% <36.36%> (ø)
...trollers/Chat/MessagesViewControllerDrafting.swift 75% <75%> (ø)
...ontrollers/Base/Main/MainSplitViewController.swift 45% <0%> (-7.5%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9d17e...e5c54b8. Read the comment docs.

Copy link
Collaborator

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking good overall! 💯 I found only one issue, after sending the message we are not cleaning the draft for a channel/group/dm. So you send it but if you close and open the channel again the message you just sent will still be there:

@cardoso
Copy link
Collaborator Author

cardoso commented Nov 13, 2018

Nice catch @filipealva . Thank you. Fixed it.

Copy link
Collaborator

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!! 💯

@filipealva filipealva merged commit 0b57890 into develop Nov 13, 2018
@filipealva filipealva deleted the fix/message_draft branch November 13, 2018 19:42
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants