Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Add back reactions handler, fix missing delegate reference and more #2317

Merged
merged 6 commits into from
Nov 16, 2018

Conversation

rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Nov 14, 2018

@RocketChat/ios

  • Add back reactions tapping handler;
  • Fixed problem when missing delegate reference during data creation;
  • Uncomment codes in the app that is now working;
  • Removed duplicated code;
  • Update colors for self-mentions, normal mentions and links;

@rafaelks rafaelks added this to the 3.2.0 milestone Nov 14, 2018
return false
}

if Array(viewModel.reactions).first(where: { $0.emoji == tappedEmoji && $0.usernames.contains(currentUser) }) != nil {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line Length Violation: Line should be 120 characters or less: currently 126 characters (line_length)

collapsibleItemsState[viewModel.differenceIdentifier] = !textAttachmentViewModel.collapsed
messagesController?.viewSizingModel.invalidateLayout(for: viewModel.differenceIdentifier)
messagesController?.viewModel.updateData()
// TODO

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Violation: TODOs should be resolved. (todo)

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@db21022). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2317   +/-   ##
==========================================
  Coverage           ?   26.09%           
==========================================
  Files              ?      439           
  Lines              ?    16058           
  Branches           ?        0           
==========================================
  Hits               ?     4190           
  Misses             ?    11868           
  Partials           ?        0
Impacted Files Coverage Δ
...at/Views/Chat/New Chat/Cells/BaseMessageCell.swift 0% <ø> (ø)
...Chat/Controllers/Chat/MessagesViewController.swift 36.63% <ø> (ø)
...ews/Chat/New Chat/Cells/BaseQuoteMessageCell.swift 0% <0%> (ø)
Rocket.Chat/Managers/AppManager.swift 42.75% <0%> (ø)
...ws/Chat/New Chat/ChatItems/ReactionsChatItem.swift 0% <0%> (ø)
Rocket.Chat/Extensions/UIColorExtension.swift 56.81% <0%> (ø)
...Controllers/Chat/ChatSections/MessageSection.swift 4.58% <0%> (ø)
...at/MessagesViewControllerMessageCellProtocol.swift 0% <0%> (ø)
...Chat/Views/Chat/New Chat/Cells/ReactionsCell.swift 0% <0%> (ø)
...t.Chat/Views/Cells/Chat/ChatMessageImageView.swift 72.09% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db21022...dce5093. Read the comment docs.

@rafaelks rafaelks changed the title [WIP][NEW] Add back reactions handler, fix missing delegate reference and more [NEW] Add back reactions handler, fix missing delegate reference and more Nov 16, 2018
Copy link
Collaborator

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awesome!! 💯

@rafaelks rafaelks merged commit 700c3de into develop Nov 16, 2018
@rafaelks rafaelks deleted the feature/reactions_support branch November 16, 2018 20:43
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants