This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Add purpose label to quote component #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 19, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2330 +/- ##
===========================================
+ Coverage 26.35% 26.36% +0.01%
===========================================
Files 440 440
Lines 16122 16278 +156
===========================================
+ Hits 4249 4292 +43
- Misses 11873 11986 +113
Continue to review full report at Codecov.
|
…ocketChat/Rocket.Chat.iOS into feat/pinned_replied_label.2307
|
Looks good to me, but I think we can merge #2335 on this PR before merging it. |
…arkdown_caching [CHORE] Only use unmanaged objects on transforming markdown cache
houndci-bot
reviewed
Nov 21, 2018
| return | ||
| } | ||
|
|
||
| if let text = force ? MessageTextCacheManager.shared.update(for: unmanagedMessage, with: theme) : MessageTextCacheManager.shared.message(for: unmanagedMessage, with: theme) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 182 characters (line_length)
| guard let identifier = message.identifier else { return nil } | ||
|
|
||
| let key = cachedKey(for: identifier) | ||
| @discardableResult func update(for message: UnmanagedMessage, with theme: Theme? = nil) -> NSMutableAttributedString? { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 123 characters (line_length)
rafaelks
approved these changes
Nov 21, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
This conforms replying to the design we have in Zeplin, and I used the same concept for pinning messages.
Closes #2307