Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Include path in OAuth callback url building #2333

Merged
merged 3 commits into from
Nov 20, 2018

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented Nov 20, 2018

@RocketChat/ios

Closes #2321

@cardoso cardoso added this to the 3.2.0 milestone Nov 20, 2018
@cardoso cardoso requested a review from rafaelks November 20, 2018 14:10
@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #2333 into develop will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2333      +/-   ##
===========================================
- Coverage     26.2%   26.09%   -0.12%     
===========================================
  Files          439      439              
  Lines        16058    16058              
===========================================
- Hits          4208     4190      -18     
- Misses       11850    11868      +18
Impacted Files Coverage Δ
Rocket.Chat/Managers/OAuthManager.swift 83.33% <ø> (ø) ⬆️
...anagers/Model/AuthManager/AuthManagerRecover.swift 36.36% <0%> (-60.61%) ⬇️
Rocket.Chat/Managers/AppManager.swift 42.75% <0%> (-4.83%) ⬇️
Rocket.Chat/Managers/PushManager.swift 24.13% <0%> (-3.45%) ⬇️
...Chat/Controllers/Chat/MessagesViewController.swift 36.63% <0%> (+3.01%) ⬆️
...ontrollers/Base/Main/MainSplitViewController.swift 52.5% <0%> (+7.5%) ⬆️
...ocket.Chat/Extensions/Models/ObjectExtension.swift 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78b8e3...b98279e. Read the comment docs.

)
}

func testCallbackUrlWithPath() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@rafaelks rafaelks merged commit e03e7fe into develop Nov 20, 2018
@rafaelks rafaelks deleted the fix/oauth_callback_with_path branch November 20, 2018 20:06
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants