Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Change from fixed constraints to relative ones #2342

Merged
merged 20 commits into from
Nov 22, 2018

Conversation

rafaelks
Copy link
Contributor

@RocketChat/ios

This PR changes the fixed constraints without taking consideration the margin to actually take and reduce the current space from left & right margins.

Now the avatar is aligned with "back button" and the message is aligned with the composer text view.

@rafaelks rafaelks added this to the 3.2.0 milestone Nov 22, 2018
@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #2342 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2342   +/-   ##
========================================
  Coverage    26.36%   26.36%           
========================================
  Files          440      440           
  Lines        16278    16278           
========================================
  Hits          4292     4292           
  Misses       11986    11986

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c9d0e...fed5302. Read the comment docs.

Copy link
Collaborator

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafaelks rafaelks merged commit 118ee0b into develop Nov 22, 2018
@rafaelks rafaelks deleted the improvement/adjust_constraints_margins branch November 22, 2018 15:44
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants