Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Add sharing & reviewing to preferences #2350

Merged
merged 5 commits into from
Nov 23, 2018

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented Nov 23, 2018

@RocketChat/ios

Closes #2318
Closes #2319

@cardoso cardoso added this to the 3.2.0 milestone Nov 23, 2018
@cardoso cardoso requested a review from rafaelks November 23, 2018 12:12
Copy link
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rafaelks
Copy link
Contributor

✅ Tests are passing but CI is timing out on iOS 12 device, gonna merge it for now.

@rafaelks rafaelks merged commit e2c59b7 into develop Nov 23, 2018
@rafaelks rafaelks deleted the feat/share_review_preferences.2318.2319 branch November 23, 2018 16:55
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants