Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX][REGRESSION] Not sending typing event #2442

Merged
merged 3 commits into from
Dec 28, 2018
Merged

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented Dec 21, 2018

@RocketChat/ios

Closes #2440

@cardoso cardoso changed the title [WIP][FIX][REGRESSION Not sending typing event [WIP][REGRESSION] Not sending typing event Dec 21, 2018
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@932f7ea). Click here to learn what that means.
The diff coverage is 36.58%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #2442   +/-   ##
=========================================
  Coverage           ?     26%           
=========================================
  Files              ?     450           
  Lines              ?   16864           
  Branches           ?       0           
=========================================
  Hits               ?    4386           
  Misses             ?   12478           
  Partials           ?       0
Impacted Files Coverage Δ
Rocket.Chat/Helpers/Throttle.swift 0% <0%> (ø)
...ntrollers/Chat/MessagesSubscriptionViewModel.swift 12.12% <0%> (ø)
...Chat/Controllers/Chat/MessagesViewController.swift 35.02% <100%> (ø)
...ontrollers/Chat/MessagesViewControllerTyping.swift 77.77% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932f7ea...6f6d03e. Read the comment docs.

@cardoso cardoso changed the title [WIP][REGRESSION] Not sending typing event [FIX][REGRESSION] Not sending typing event Dec 24, 2018
@cardoso cardoso requested a review from rafaelks December 24, 2018 21:17
@cardoso
Copy link
Collaborator Author

cardoso commented Dec 24, 2018

@rafaelks I think this one is ready... But there's a delay in the server, we send the event and only a few seconds later the typing... appears. And in unstable.rocket.chat I can't get it to work at all... I think this is a server-side issue.

Can you test on Android and see if this is server-side? Test on open if there's a delay, and if unstable is broken.

@rafaelks
Copy link
Contributor

@cardoso From my tests, you're only calling the WebSocket call when user stops typing for a few seconds, can you check it again?

@rafaelks rafaelks added this to the 3.3.0 milestone Dec 26, 2018
@cardoso
Copy link
Collaborator Author

cardoso commented Dec 26, 2018

@rafaelks nice catch. I should be using throttling instead of debouncing. Fixed that. Thanks.

@rafaelks rafaelks merged commit d17ed72 into develop Dec 28, 2018
@rafaelks rafaelks deleted the fix/typing.2440 branch December 28, 2018 11:39
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants