Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Issues with Dynamic Typing being different than expected #2478

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Jan 7, 2019

@RocketChat/ios

Closes #2439

@rafaelks rafaelks added this to the 3.3.0 milestone Jan 7, 2019
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #2478 into develop will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2478      +/-   ##
===========================================
+ Coverage    26.32%   26.45%   +0.12%     
===========================================
  Files          456      456              
  Lines        16909    16895      -14     
===========================================
+ Hits          4452     4469      +17     
+ Misses       12457    12426      -31
Impacted Files Coverage Δ
...ocket.Chat/Helpers/MessageTextFontAttributes.swift 84.44% <100%> (+3.08%) ⬆️
...ocket.Chat/Extensions/Models/ObjectExtension.swift 80% <0%> (-20%) ⬇️
...ontrollers/Base/Main/MainSplitViewController.swift 45% <0%> (-7.5%) ⬇️
...Chat/Controllers/Chat/MessagesViewController.swift 31.48% <0%> (-2.98%) ⬇️
Rocket.Chat/Managers/AppManager.swift 40.58% <0%> (+4.11%) ⬆️
Rocket.Chat/Managers/PushManager.swift 34.48% <0%> (+10.34%) ⬆️
...Chat/Models/Subscription/SubscriptionQueries.swift 100% <0%> (+30%) ⬆️
Rocket.Chat/Extensions/Models/AuthExtensions.swift 100% <0%> (+33.33%) ⬆️
...anagers/Model/AuthManager/AuthManagerRecover.swift 96.96% <0%> (+60.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba97b30...82b2d53. Read the comment docs.

@rafaelks rafaelks merged commit 31c538a into develop Jan 7, 2019
@rafaelks rafaelks deleted the bug/font_sizing_adjutments branch January 7, 2019 12:16
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant