Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Try to open links as an universal URL instead of directly on the browser #2590

Merged

Conversation

rafaelks
Copy link
Contributor

@RocketChat/ios

Closes #2567

@rafaelks rafaelks added this to the 3.4.0 milestone Mar 20, 2019
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #2590 into develop will decrease coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2590      +/-   ##
===========================================
- Coverage    26.16%   25.98%   -0.18%     
===========================================
  Files          463      463              
  Lines        17198    17213      +15     
===========================================
- Hits          4499     4472      -27     
- Misses       12699    12741      +42
Impacted Files Coverage Δ
Rocket.Chat/Managers/WebBrowserManager.swift 3.38% <0%> (-1.16%) ⬇️
...anagers/Model/AuthManager/AuthManagerRecover.swift 36.36% <0%> (-60.61%) ⬇️
Rocket.Chat/Extensions/Models/AuthExtensions.swift 66.66% <0%> (-33.34%) ⬇️
...Chat/Models/Subscription/SubscriptionQueries.swift 70% <0%> (-30%) ⬇️
Rocket.Chat/Managers/PushManager.swift 24.13% <0%> (-10.35%) ⬇️
Rocket.Chat/Managers/AppManager.swift 36.04% <0%> (-4.07%) ⬇️
...Chat/Controllers/Chat/MessagesViewController.swift 34.25% <0%> (+2.75%) ⬆️
...ontrollers/Base/Main/MainSplitViewController.swift 52.5% <0%> (+7.5%) ⬆️
...ocket.Chat/Extensions/Models/ObjectExtension.swift 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe2c73...1bf1f22. Read the comment docs.

@rafaelks rafaelks merged commit b22da9f into develop Mar 20, 2019
@rafaelks rafaelks deleted the chore/prefer_universallinks_instead_webview_always branch March 20, 2019 11:54
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant