Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Change theme for MBProgressHUD #2600

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

rudrankriyam
Copy link
Contributor

@RocketChat/ios

Closes #2577

Added the bezel.view = white, so that the view is visible in dark and black themes.

Before / After :

Screenshot 2019-03-21 at 8 21 51 PM
Screenshot 2019-03-21 at 8 19 45 PM

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #2600 into develop will increase coverage by 0.68%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2600      +/-   ##
===========================================
+ Coverage    25.99%   26.67%   +0.68%     
===========================================
  Files          463      456       -7     
  Lines        17203    16906     -297     
===========================================
+ Hits          4472     4510      +38     
+ Misses       12731    12396     -335
Impacted Files Coverage Δ
Rocket.Chat/Theme/ThemeableViews.swift 52.63% <100%> (+10.17%) ⬆️
...ocket.Chat/Extensions/Models/ObjectExtension.swift 80% <0%> (-20%) ⬇️
...ontrollers/Base/Main/MainSplitViewController.swift 45% <0%> (-7.5%) ⬇️
...t/Views/Subscriptions/SubscriptionsTitleView.swift 12.5% <0%> (-4.17%) ⬇️
...Chat/Controllers/Chat/MessagesViewController.swift 31.49% <0%> (-2.76%) ⬇️
Rocket.Chat/Extensions/DateExtension.swift 64.28% <0%> (-2.39%) ⬇️
Rocket.Chat/Models/Subscription/Subscription.swift 47.61% <0%> (-1.27%) ⬇️
...ences/Profile/EditProfileTableViewController.swift 23.94% <0%> (-0.12%) ⬇️
...Chat/Models/Mapping/SubscriptionModelMapping.swift 87.71% <0%> (ø) ⬆️
Rocket.Chat/Models/User/User.swift 91.42% <0%> (ø) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b49b6...711e313. Read the comment docs.

@rafaelks
Copy link
Contributor

Looks good, thanks @snuff4!

@rafaelks rafaelks merged commit cec6295 into RocketChat:develop Mar 22, 2019
@rudrankriyam rudrankriyam deleted the MBProgressHUDTheme branch March 22, 2019 14:57
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants