[CHORE] Update MobilePlayer Pod for iPhone XR/XS Max support #2641
Conversation
|
|
||
| let iPhoneX = UIDevice().userInterfaceIdiom == .phone && UIScreen.main.nativeBounds.height == 2436 | ||
| let landscape = UIScreen.main.bounds.height != 812 | ||
| let iPhoneX = UIDevice.current.userInterfaceIdiom == .phone && (UIScreen.main.nativeBounds.height == 2688 || UIScreen.main.nativeBounds.height == 2436 || UIScreen.main.nativeBounds.height == 1792) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 204 characters (line_length)
| @@ -640,3 +643,4 @@ extension MobilePlayerViewController: SliderDelegate { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
File Line Length Violation: File should contain 400 lines or less: currently contains 646 (file_length)
Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)
| @@ -358,6 +358,14 @@ open class MobilePlayerViewController: MPMoviePlayerViewController { | |||
| getViewForElementWithIdentifier("action")?.isHidden = isEmpty | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| let scanner = Scanner(string: hex) | ||
| var hexValue = CUnsignedLongLong(0) | ||
| if scanner.scanHexInt64(&hexValue) { | ||
| switch (hex.characters.count) { | ||
| switch (hex.count) { |
There was a problem hiding this comment.
Control Statement Violation: if, for, guard, switch, while, and catch statements shouldn't unnecessarily wrap their conditionals or arguments in parentheses. (control_statement)
| @@ -36,7 +36,7 @@ extension Timer { | |||
| extension UIControl { | |||
|
|
|||
| @discardableResult | |||
| func addCallback(callback: @escaping () -> Void, forControlEvents controlEvents: UIControlEvents) -> UnsafeMutableRawPointer { | |||
| func addCallback(callback: @escaping () -> Void, forControlEvents controlEvents: UIControl.Event) -> UnsafeMutableRawPointer { | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)
Codecov Report
@@ Coverage Diff @@
## develop #2641 +/- ##
===========================================
- Coverage 26.17% 26.02% -0.16%
===========================================
Files 463 463
Lines 17224 17224
===========================================
- Hits 4509 4482 -27
- Misses 12715 12742 +27
Continue to review full report at Codecov.
|
|
👍 |
@RocketChat/ios
Closes #2633