Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Replace URBMediaFocusViewController for SimpleImageViewer #625

Merged
merged 3 commits into from
Sep 8, 2017

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented Sep 7, 2017

@RocketChat/ios

Closes #621

@cardoso
Copy link
Collaborator Author

cardoso commented Sep 7, 2017

TODO:

  • Check if openImage(attachment:) is working

@cardoso cardoso changed the title Replace URBMediaFocusViewController for SimpleImageViewer [WIP][FIX] Replace URBMediaFocusViewController for SimpleImageViewer Sep 7, 2017
@cardoso cardoso changed the title [WIP][FIX] Replace URBMediaFocusViewController for SimpleImageViewer [FIX] Replace URBMediaFocusViewController for SimpleImageViewer Sep 7, 2017
@cardoso
Copy link
Collaborator Author

cardoso commented Sep 7, 2017

Had to fork SimpleImageViewer because of some forced unwraps causing crashes when dismissing via panning.

@cardoso cardoso self-assigned this Sep 7, 2017
@cardoso cardoso requested a review from rafaelks September 7, 2017 19:56
@rafaelks rafaelks modified the milestone: 1.3.0 Sep 8, 2017
@cardoso cardoso force-pushed the fix/i621_rotate_image branch from ce9b546 to 52fffe6 Compare September 8, 2017 12:58
@rafaelks rafaelks removed the 🚧 wip label Sep 8, 2017
@rafaelks rafaelks merged commit 8800370 into RocketChat:develop Sep 8, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants