This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 439
[NEW] Room names with special chars #684
Merged
rafaelks
merged 8 commits into
RocketChat:develop
from
falcaoaugustos:feature/room_name_with_special_chars.615
Sep 21, 2017
Merged
[NEW] Room names with special chars #684
rafaelks
merged 8 commits into
RocketChat:develop
from
falcaoaugustos:feature/room_name_with_special_chars.615
Sep 21, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@falcaoaugustos Looking very good, thanks for your PR! Could you also write a few tests related to the setting and the displayName result? That would be perfect 👌 |
For reference, we have a similar test for this class: Rocket.Chat.iOS/Rocket.ChatTests/Models/SubscriptionSpec.swift Lines 121 to 152 in 6f364fd
|
Thank you, I will do it. |
…thub.com/falcaoaugustos/Rocket.Chat.iOS into feature/room_name_with_special_chars.615
@falcaoaugustos Looking great! Is this ready to be merged? |
This is ready now. Thank you. |
rafaelks
approved these changes
Sep 21, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Closes #615
I implemented the settings parameter to allow room names with special chars.
TODO: