Skip to content

Commit

Permalink
Update three-insects-roll.md
Browse files Browse the repository at this point in the history
  • Loading branch information
ggazzo authored Jan 24, 2025
1 parent 633edec commit 65069f9
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions .changeset/three-insects-roll.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,4 @@
"@rocket.chat/meteor": patch
---

Fixes a missconception about `/v1/livechat/tags/:tagId`

the type definition doesnt consider null/empty results
```
'/v1/livechat/tags/:tagId': {
GET: () => ILivechatTag;
};
```

the code returns `ILivechatTag | { body: null }` which is weird/wrong.

now if we cannot find the tag returns a 404 result
Fixes a missconception about `/v1/livechat/tags/:tagId` returning 404 if tag is not found

0 comments on commit 65069f9

Please # to comment.