Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Restore room scroll position #34908

Merged
merged 5 commits into from
Jan 15, 2025
Merged

fix: Restore room scroll position #34908

merged 5 commits into from
Jan 15, 2025

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jan 8, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  • Go to room A
  • Scroll up to some message
  • Go to room B and come back to room A
  • The scroll position should be restored and should be same as when room A was left

Further comments

CORE-916

Copy link
Contributor

dionisio-bot bot commented Jan 8, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 209dfdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34908/

Built to branch gh-pages at 2025-01-15 14:53 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (e6eff85) to head (209dfdc).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34908      +/-   ##
===========================================
- Coverage    59.13%   59.12%   -0.01%     
===========================================
  Files         2819     2819              
  Lines        67885    67368     -517     
  Branches     15120    15011     -109     
===========================================
- Hits         40141    39834     -307     
+ Misses       24912    24723     -189     
+ Partials      2832     2811      -21     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review January 8, 2025 13:26
@yash-rajpal yash-rajpal requested a review from a team as a code owner January 8, 2025 13:26
@yash-rajpal yash-rajpal added this to the 7.3.0 milestone Jan 8, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jan 15, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 15, 2025
@kodiakhq kodiakhq bot merged commit 62660fc into develop Jan 15, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/restore-scroll branch January 15, 2025 16:25
This was referenced Jan 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants