-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Allow users to force close Omnichannel rooms #34940
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 49a1dde The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34940 +/- ##
===========================================
- Coverage 59.12% 59.12% -0.01%
===========================================
Files 2819 2819
Lines 67859 67856 -3
Branches 15114 15115 +1
===========================================
- Hits 40125 40123 -2
+ Misses 24906 24905 -1
Partials 2828 2828
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
Proposed changes (including videos or screenshots)
The new param passed to
rooms.closeByUser
endpoint allows users to forcefully close an omnichannel conversation.This may come handy when a room, for X or Y reason ends up in a bad state, given an error during the closing procedure, or an update after the room has been closed. Currently, calling the API again will throw an error, as the room state is not valid and as such we avoid updating it.
This new setting will allow admins to allow the
forceClose
parameter, which will skip most of the validations and run the closing process again.Issue(s)
https://rocketchat.atlassian.net/browse/CONN-475
Steps to test or reproduce
Further comments