Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Allow users to force close Omnichannel rooms #34940

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Jan 13, 2025

Proposed changes (including videos or screenshots)

The new param passed to rooms.closeByUser endpoint allows users to forcefully close an omnichannel conversation.
This may come handy when a room, for X or Y reason ends up in a bad state, given an error during the closing procedure, or an update after the room has been closed. Currently, calling the API again will throw an error, as the room state is not valid and as such we avoid updating it.
This new setting will allow admins to allow the forceClose parameter, which will skip most of the validations and run the closing process again.

Issue(s)

https://rocketchat.atlassian.net/browse/CONN-475

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 13, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 49a1dde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/rest-typings Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/core-typings Minor
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 13, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34940/

Built to branch gh-pages at 2025-01-16 21:15 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (f777d9e) to head (49a1dde).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34940      +/-   ##
===========================================
- Coverage    59.12%   59.12%   -0.01%     
===========================================
  Files         2819     2819              
  Lines        67859    67856       -3     
  Branches     15114    15115       +1     
===========================================
- Hits         40125    40123       -2     
+ Misses       24906    24905       -1     
  Partials      2828     2828              
Flag Coverage Δ
unit 75.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added this to the 7.3.0 milestone Jan 13, 2025
@KevLehman KevLehman marked this pull request as ready for review January 14, 2025 17:51
@KevLehman KevLehman requested review from a team as code owners January 14, 2025 17:51
tapiarafael
tapiarafael previously approved these changes Jan 15, 2025
.changeset/eight-humans-sip.md Outdated Show resolved Hide resolved
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jan 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 16, 2025
@kodiakhq kodiakhq bot merged commit c75d771 into develop Jan 17, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/force-close-omni-rooms branch January 17, 2025 03:37
This was referenced Jan 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants