Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changing the return value in didFinishLaunchingWithOptions crashes the application from SDK version above 8.0.0 #338

Closed
klim-branch opened this issue Jun 7, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@klim-branch
Copy link

Hi @RodrigoSMarques this is Kun from the Branch integration team!

Describe the bug
When the customer make return value change in didFinishLaunchingWithOptions method of the AppDelegate class the app crashes without any logs on flutter-sdk-version >=8.0.0

To Reproduce
Change the return value to true didFinishLaunchingWithOptions method

@UIApplicationMain @objc class AppDelegate: FlutterAppDelegate { override func application( _ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? ) -> Bool { GeneratedPluginRegistrant.register(with: self) return true } }

image

Screenshots

If you build an app with return true as mentioned above and click on a branch link , it would open the app and crash without any proper logs

Video Behaviour :
https://drive.google.com/file/d/1mp3svEGk4ul9VHYHQuFzxtwRgLqthrll/view?usp=sharing

Example Testing Link used:
https://musicwiki.app.link/Senhang
https://musicwiki.app.link/DRb6YE9a1Jb

Additional Context

  • This issue is happening only from the SDK version above 8.0.0. Previous versions such as 7.1.0 does not appears to have this issue.

  • From the netcore SDK, it is a requirement to return true. Therefore, there is no walkaround for this current solution.

  • I will send out the testing code base via email. Let me know if you are okay with it.

Please let me know if you need anything from my end!

@klim-branch klim-branch added the bug Something isn't working label Jun 7, 2024
@RodrigoSMarques
Copy link
Owner

Hi @klim-branch

I will check!

RodrigoSMarques added a commit that referenced this issue Jul 12, 2024
## 8.0.4
### ⚠️ BREAKING CHANGE
This is a major release which contains breaking API changes.
#### ⚠️ SDK Initialization Changed
* `useTestKey` parameter is no longer supported at `FlutterBranchSdk.init()`.

Check the instructions in `README.MD` on how to activate the `key_test_`.

### 🐛 Bug Fixes
* Fix issue #347: ios plugin v8.0.3 crashes when no url is returned
* Fix issue #338: Changing the return value in didFinishLaunchingWithOptions crashes the application from SDK version above 8.0.0
@RodrigoSMarques
Copy link
Owner

Hi @klim-branch

New version available: 8.0.4

@klim-branch
Copy link
Author

Amazing! Let me test from our side as well! @RodrigoSMarques I will share the update below.

@klim-branch
Copy link
Author

Confirming the issue has been resolved! Thank you for the support @RodrigoSMarques.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants