-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: show flags (filter, etc.) by default #20
Conversation
…for disabling them or changing their position
ac02024
to
71c5dc2
Compare
@blackdaemon, would you mind testing out if this works alright for you? If you have time, the setup options too. Otherwise, don't worry, I'll just merge and hope if works for everyone |
@Rolv-Apneseth It works but it does not cooperate with the tabs properly. I disabled all other plugins to be sure.
|
I think it's maybe unrelated to your latest changes, should I try with master branch? |
Tried on main branch, this problem does not relate to your latest changes and is present on main. New issue should be opened for this. |
Could you also give me |
Reagring measuring the length of the starship line, I did something similar in python and go and I strip the ansi characters using known regular expression and then get the length of the string which is then just bare character count. |
My yazi version is: Installed as: |
You can if you want, but I'd say people with problems specific to their config can just open a new issue.
Feel free to have a go at it if you want. Trimming the correct number of characters to fit the flags is not so simple.
I'll see if there's been changes to the tab event. You're saying switching tabs doesn't update the |
Yes, switching to new tab and back keeps the last tab info. |
Anyway, seems this is OK to merge for now. Thanks for testing it out! I'll open a new issue for the tab thing. |
Fixes #19
This will by default show the flags, such as filter, find etc., right after the starship prompt.
I've also added setup options to either move the flags to before the starship prompt, or just disable them entirely.
This solution won't work by default with starship themes which are meant to take up the full width of the terminal, so either disable it entirely, ignore it (you won't see it anyway) or, if it is acceptable, allow it to show before the prompt, which will cut off the right side of your prompt when showing flags.