Fix normalizing file:// paths with special characters #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halaei
force-pushed
the
fix-android-file-scheme-2
branch
from
ae78441 to
06883c6
Compare
|
Hi, |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting joltup#736
File uris with space and other special characters are not correctly normalized. The fix is to removing 3 lines of code on
normalizePath()because the correct normalization code already exists inPathResolver.getRealPathFromURI().Example input:
file:///storage/emulated/0/Foo%20BarCorrect output:
/storage/emulated/0/Foo Bar.Current (wrong) output:
/storage/emulated/0/Foo%20Bar.PS: Is it possible for you to take a look at other PRs in joltup#736 as well? I know that's a lot to ask, so I get it if you say no :)