Please revert/remove/fix the conditional inclusion of bigdecimal in gemspec

[tagliala]

money/money.gemspec

Line 18 in 2ef600a

s.add_dependency "bigdecimal", "~> 3.1" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('6.19.0')

• This is checking for Ruby version > 6.19, but I guess it wanted to check for money version itself.
• (IIRC) It is not a good practice to add conditionals in the gemspec, since this will be also evaluated on rubygems.org, regardless of RUBY version
• Removing the conditional works for all specified ruby versions, back to Ruby 2.3. It will install bigdecimal 1.4.4 and work

$ rake
~/.rvm/rubies/ruby-2.3.8/bin/ruby -w -I/~/.rvm/gems/ruby-2.3.8/gems/rspec-core-3.13.0/lib:/~/.rvm/gems/ruby-2.3.8/gems/rspec-support-3.13.1/lib /~/.rvm/gems/ruby-2.3.8/gems/rspec-core-3.13.0/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 16175
..................................................................................................................................................................................................................................................................[WARNING] Using :ruby format when importing rates is potentially unsafe and might lead to remote code execution via Marshal.load deserializer. Consider using safe alternatives such as :json and :yaml.
..................../~/dev/money/spec/rates_store/memory_spec.rb:59: warning: instance variable @index not initialized
/~/dev/money/spec/rates_store/memory_spec.rb:59: warning: instance variable @index not initialized
........................................................................................................................................................................................................................................

Finished in 0.15704 seconds (files took 0.42982 seconds to load)
510 examples, 0 failures

Randomized with seed 16175