Skip to content

Change the name of wait_list to wait_queue_head in CondVar #1048

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
y86-dev opened this issue Dec 13, 2023 · 2 comments
Closed

Change the name of wait_list to wait_queue_head in CondVar #1048

y86-dev opened this issue Dec 13, 2023 · 2 comments
Labels
good first issue Good for newcomers • lib Related to the `rust/` library.

Comments

@y86-dev
Copy link
Member

y86-dev commented Dec 13, 2023

CondVar currently has a field called wait_list, but its type is Opaque<bindings::wait_queue_head>. Change the name to wait_queue_head to avoid confusion, since fields that are named wait_list normally have the type struct list_head.


This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes, to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and so on. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.

Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel.

@y86-dev y86-dev added • lib Related to the `rust/` library. good first issue Good for newcomers labels Dec 13, 2023
AdilDyer added a commit to AdilDyer/linux that referenced this issue Dec 13, 2023
AdilDyer added a commit to AdilDyer/linux that referenced this issue Dec 13, 2023
@vobst
Copy link
Member

vobst commented Jan 7, 2024

@AdilDyer are you still working on that one? Otherwise I‘d like to take the opportunity to learn how to submit a patch to the mailing list (never done that before).

@y86-dev In any case I'd be interested what "test your changes" means in this context? Anything besides the things mentioned in the contributing guidelines.

Update:
nvm, its already done https://lore.kernel.org/rust-for-linux/20240105012930.1426214-1-charmitro@posteo.net/

@bjorn3
Copy link
Member

bjorn3 commented Aug 22, 2024

@bjorn3 bjorn3 closed this as completed Aug 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers • lib Related to the `rust/` library.
Development

No branches or pull requests

3 participants