Update to a new nightly version #288
Conversation
This comment has been minimized.
This comment has been minimized.
|
Looks like the ppc builder is unhappy here. |
|
Yeah, seems like there's still something going wrong after LLVM 12. Only tested x86_64 locally so there was a good chance that one of the other platforms miscompiles. Will try to take a look at the failure. |
|
Thanks!
…On Sat, May 22, 2021 at 11:27 AM Boris-Chengbiao Zhou ***@***.***> wrote:
Yeah, seems like there's still something going wrong after LLVM 12. Only tested x86_64 locally so there was a good chance that one of the other platforms miscompiles. Will try to take a look at the failure.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
All that is necessary for evil to succeed is for good people to do nothing.
|
|
Thanks a lot for rust-lang/rust#85276 -- I mentioned in the last informal meeting we still had relocations going on but did not have time to look into what was going on, so it is great to see that being solved. For the CI failure, I would suggest giving a quick try at disabling optimizations in the Hacking menu to discard LLVM opt issues. |
|
Follow up PR to fix ppc: rust-lang/rust#85700 Thanks so much for chasing down this details! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks like there's a new clippy error. |
This comment has been minimized.
This comment has been minimized.
|
Apparently |
|
Good catch, created issue. |
Includes rust-lang/rust#83592, rust-lang/rust#85276 and rust-lang/rust#85700 which are needed to build correctly again after rustc's upgrade to LLVM 12. Signed-off-by: Boris-Chengbiao Zhou <bobo1239@web.de>
|
Review of
|
|
Removed the clippy fix from the commit message again since #319 took care of that. |
|
Yes! |
Offset into the page should also be considered while calculating a physical address for struct dma_debug_entry. page_to_phys() just shifts the value PAGE_SHIFT bits to the left so offset part is zero-filled. An example (wrong) debug assertion failure with CONFIG_DMA_API_DEBUG enabled which is observed during systemd boot process after recent dma-debug changes: DMA-API: e1000 0000:00:03.0: cacheline tracking EEXIST, overlapping mappings aren't supported WARNING: CPU: 4 PID: 941 at kernel/dma/debug.c:596 add_dma_entry CPU: 4 UID: 0 PID: 941 Comm: ip Not tainted 6.12.0+ Rust-for-Linux#288 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 RIP: 0010:add_dma_entry kernel/dma/debug.c:596 Call Trace: <TASK> debug_dma_map_page kernel/dma/debug.c:1236 dma_map_page_attrs kernel/dma/mapping.c:179 e1000_alloc_rx_buffers drivers/net/ethernet/intel/e1000/e1000_main.c:4616 ... Found by Linux Verification Center (linuxtesting.org). Fixes: 9d4f645 ("dma-debug: store a phys_addr_t in struct dma_debug_entry") Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> [hch: added a little helper to clean up the code] Signed-off-by: Christoph Hellwig <hch@lst.de>
Includes rust-lang/rust#83592 and rust-lang/rust#85276 which were needed
to build correctly again after rustc's upgrade to LLVM 12.
Fixes #135.