set realtime priority for stream threads in alsa and wasapi #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like linux CI is failing due to dbus not being installed on the linux runners. Windows CI is failing cause I messed up :P |
edwloef
force-pushed
the
audio_thread_priority
branch
2 times, most recently
from
5b4d56f to
6014a3c
Compare
implements RustAudio#939. As someone who doesn't know a whole lot about cpal's inner workings it looks to me like these are the only threads that the library spawns itself, leading me to think these are the only threads that require manual priority changes. However, `audio_thread_priority` claims to also support MacOS, so maybe someone could look into whether that's applicable here?
edwloef
force-pushed
the
audio_thread_priority
branch
from
6014a3c to
d61ef6d
Compare
|
Alright, windows is fixed. Should I update the CI and readme to include dbus on linux? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #939. As someone who doesn't know a whole lot about cpal's inner workings it looks to me like these are the only threads that the library spawns itself, leading me to think these are the only threads that require manual priority changes. However,
audio_thread_priorityclaims to also support MacOS, so maybe someone could look into whether that's applicable here?I'm not too massive of a fan of
eprintln!here, however I think the failure should be shown but not prevent the audio thread from running.I've tested this on my Linux laptop, some verification that this also works for the folks on WASAPI and the BSD's would be nice.