-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cross bindings #77
Cross bindings #77
Conversation
@Janonard i can add bindings for *-pc-windows-gnu targets but i don't know if it worth. Even if it's not identical to x86_64-pc-windows-msvc, it's fully compatible. The only noticeable difference is the signed/unsigned bindings on enum, which is irrelevant. |
I guess you can merge the gnu and msvc bindings. I used to be a little anxious about mixing bindings that aren't 100% identical, but given that the difference between signed and unsigned bindings is never relevant (and would even be annoying when you want to target both targets), I now think it's okay. Also, does the existence of this PR mean that you're abandoning #64? |
Yes. If i remember correctly, you forked it, did some change, and merged back to develop branch |
@Janonard i updated the supported target section of README.md. I tried to separate binding concept from supported target concept. I'm not sure if my explanation are clear between supported target, usable target, experimental feature gated by |
I think you mean the right thing, but it isn't that clear yet: A target has three states: It may be missing from the |
I fixed explanation about target support requirement. For the rest, i don't know how to make it better. Maybe by presenting tables differently ? One difficulty in explanations is the "experimental-targets" feature, it doesn't really act as a gate for "unsupported but usable" targets. It may more clear if we rename this feature as "experimental-bindings", isn't it ? |
#80 is this better? If so, please pull |
i hope i fixed all my errors. Some of them was not detected by the automatic check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It add experimental bindings for arm and aarch64
Also update and improve the systool README