Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PaddingScheme being !Send makes things harder #214

Closed
gdesmott opened this issue Oct 20, 2022 · 2 comments · Fixed by #215
Closed

PaddingScheme being !Send makes things harder #214

gdesmott opened this issue Oct 20, 2022 · 2 comments · Fixed by #215

Comments

@gdesmott
Copy link
Contributor

See librespot-org/librespot#1065

PaddingScheme is !Send making it impossible to use it in async code requiring Send futures.

Is there any way this could be prevented?

@tarcieri
Copy link
Member

It's probably because the Box<DynDigest> members aren't Box<DynDigest + Send>.

@gdesmott alternatively you could use e.g. rsa::pkcs1v15::{SigningKey, VerifyingKey} or rsa::pss::{SigningKey, VerifyingKey} which are Send (+ Sync) maybe?

gdesmott added a commit to gdesmott/RSA that referenced this issue Oct 20, 2022
It's more convenient for users.

Fix RustCrypto#214
@gdesmott
Copy link
Contributor Author

It's probably because the Box<DynDigest> members aren't Box<DynDigest + Send>.

Indeed, and it's quite easy to fix: #215

gdesmott added a commit to gdesmott/RSA that referenced this issue Oct 20, 2022
tarcieri pushed a commit that referenced this issue Oct 24, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants