feat: switch from num-bigint-dig to crypto-bigint #394

dignifiedquire · 2023-11-29T13:23:38Z

~~Very, very WIP~~

Not anymore, this is ready for review.
Replaces all usage of num-bigint-dig based BigInt usage with the new crypto-bigint crate, using BoxedUint

Current known issue is that we do have a performance regression, which will be able to get rid of over time:

# crypto-bigint

# macbook m1
test bench_rsa_2048_pkcsv1_decrypt      ... bench:   7,184,387.50 ns/iter (+/- 425,598.69)
test bench_rsa_2048_pkcsv1_sign_blinded ... bench:  13,453,579.10 ns/iter (+/- 686,276.31)

# AMD
test bench_rsa_2048_pkcsv1_decrypt      ... bench:   9,260,832.80 ns/iter (+/- 30,013.38)
test bench_rsa_2048_pkcsv1_sign_blinded ... bench:  16,610,079.40 ns/iter (+/- 251,292.53)

# master

# macbook m1
test bench_rsa_2048_pkcsv1_decrypt      ... bench:   1,117,479.15 ns/iter (+/- 31,334.30)
test bench_rsa_2048_pkcsv1_sign_blinded ... bench:   1,337,437.55 ns/iter (+/- 88,624.39)

# AMD
test bench_rsa_2048_pkcsv1_decrypt      ... bench:   1,414,348.80 ns/iter (+/- 12,585.71)
test bench_rsa_2048_pkcsv1_sign_blinded ... bench:   1,685,650.00 ns/iter (+/- 11,105.71)

TODOs

src/algorithms/rsa.rs

src/algorithms/generate.rs

tarcieri

I could continue scanning this PR looking for improvements, but I don't see any worth blocking a merge on. I can retroactively file some issues perhaps.

dignifiedquire · 2025-01-30T22:09:03Z

@tarcieri updated to the latest version, and fixed a subtle padding bug that I found, please take a final look before I merge

src/algorithms/generate.rs

src/key.rs

src/pkcs1v15.rs

src/pkcs1v15/signature.rs

tarcieri · 2025-02-01T23:20:00Z

src/pkcs1v15/signing_key.rs

-    pub fn random<R: CryptoRngCore + ?Sized>(rng: &mut R, bit_size: usize) -> Result<Self> {
+    pub fn random<R: CryptoRngCore>(rng: &mut R, bit_size: usize) -> Result<Self> {


Is there a particular reason you're getting rid of ?Sized on these? It makes it possible to use a dyn CryptoRngCore

Is there a particular reason you're getting rid of ?Sized on these? It makes it possible to use a dyn CryptoRngCore

I don't think so, can revert probably

I checked, and I removed it because I can't pass that constraint to crypto_primes

Adding it to crypto-primes is unfortunately blocked by crypto-bigint not supporting it.

Made RustCrypto/crypto-bigint#760 for that

tarcieri · 2025-02-01T23:20:41Z

src/pss.rs

+
+    let em = BoxedUint::from_be_slice(
+        &em,
+        crate::traits::keys::PublicKeyParts::n_bits_precision(priv_key),


Similar concern re: PublicKeyParts

tarcieri · 2025-02-01T23:21:12Z

src/pss/signature.rs

+        #[cfg(feature = "std")]
+        let inner = inner
+            .map_err(|e| Box::new(e) as Box<dyn core::error::Error + Send + Sync + 'static>)?;
+        #[cfg(not(feature = "std"))]
+        let inner = inner.map_err(|_| signature::Error::new())?;


Ugh, should really fix this upstream in the signature crate

tarcieri

Various little nits but things are looking a lot better on this pass

tarcieri · 2025-02-12T20:18:06Z

@dignifiedquire can we land this?

fjarri · 2025-02-12T20:51:20Z

There's a minor thing of needing the libm dependency (#394 (comment)), but I can make a separate PR for that

fjarri · 2025-02-12T20:52:54Z

Also the 6-10x performance drop is quite surprising, but that can be addressed in a follow-up as well.

dignifiedquire · 2025-02-12T21:42:37Z

There's a minor thing of needing the libm dependency (#394 (comment)), but I can make a separate PR for that

I removed that, there is some other follow ups from you and @tarcieri I wanted to get to, but we can also merge as is

dignifiedquire · 2025-02-13T08:47:13Z

Thank you everyone who helped make this a reality! And sorry for this taking so long..

Notably includes #394 which migrates to `crypto-bigint`

dignifiedquire added 4 commits November 29, 2023 14:23

implement minimal decryption routine using BoxedUint

fcc3577

convert internals to use crypto-bigint

bc92994

store residue_params

21b7c81

implement blinding (tests failing currently)

98a86a2

dignifiedquire mentioned this pull request Nov 29, 2023

Migrating from num-bigint(-dig) to crypto-bigint #390

Closed

dignifiedquire added 3 commits November 29, 2023 17:42

fix blinding and fold in new impl

f4131c5

implement basic widening strategy

2dafa35

fix some widening/padding

cb7d486

tarcieri reviewed Nov 29, 2023

View reviewed changes

src/algorithms/rsa.rs Outdated Show resolved Hide resolved

dignifiedquire added 2 commits November 29, 2023 20:39

cleanup rsa algorithm

fd19c88

docs and debugging

813fe77

tarcieri mentioned this pull request Nov 30, 2023

Splitting up crate to reduce advisory blast radius? #395

Closed

dignifiedquire added 5 commits November 30, 2023 22:07

fix crt value calculation in decryption

efc4460

cleanup

9fde5fb

convert core key algorithms

3f1751e

cache p and q params

b795c22

convert hazmt decrypt interface

6481533

tarcieri reviewed Dec 1, 2023

View reviewed changes

src/algorithms/rsa.rs Outdated Show resolved Hide resolved

dignifiedquire added 6 commits December 1, 2023 10:33

use crypto-bigint for encryption

97f8fa4

convert more internal use to crypto-bigint

cc3f03b

use crypto-bigint in signatuers

d02fbe7

convert from_components internally and pss signature

a5fc616

cleanup rsapublickey

7211bfa

store exponent as u64

c071ba1

sebadob mentioned this pull request Dec 1, 2023

Marvin Attack: potential key recovery through timing sidechannels sebadob/rauthy#197

Open

dignifiedquire added 5 commits December 2, 2023 13:16

fix: handle large m2

a811be0

cache boxedresiduie for qinv

102953d

use some assign operations

57d6f95

update to latest crypto-bigint

2cdd37c

update crypto-bigint

f7fa669

YgorSouza reviewed Jan 21, 2025

View reviewed changes

src/algorithms/generate.rs Outdated Show resolved Hide resolved

lokka30 mentioned this pull request Jan 26, 2025

RSA is slow Pumpkin-MC/Pumpkin#119

Open

1 task

tarcieri approved these changes Jan 28, 2025

View reviewed changes

update to latest deps & fix padding issue

9571ec9

fix: implement ln fallback locally

3a0201c

dignifiedquire force-pushed the const-crypto-biguint branch from 7e9dffd to 3a0201c Compare January 31, 2025 11:32

praseodym reviewed Jan 31, 2025

View reviewed changes

src/algorithms/generate.rs Show resolved Hide resolved

tarcieri reviewed Feb 1, 2025

View reviewed changes

src/key.rs Outdated Show resolved Hide resolved

tarcieri reviewed Feb 1, 2025

View reviewed changes

src/pkcs1v15.rs Outdated Show resolved Hide resolved

tarcieri reviewed Feb 1, 2025

View reviewed changes

src/pkcs1v15/signature.rs Show resolved Hide resolved

tarcieri reviewed Feb 1, 2025

View reviewed changes

tarcieri approved these changes Feb 1, 2025

View reviewed changes

dignifiedquire added 3 commits February 13, 2025 09:28

apply CR

cd906e7

update serdect

1f0bc91

Merge remote-tracking branch 'origin/master' into const-crypto-biguint

578ada0

dignifiedquire merged commit f7d1214 into master Feb 13, 2025
11 checks passed

dignifiedquire deleted the const-crypto-biguint branch February 13, 2025 08:46

tarcieri mentioned this pull request Feb 13, 2025

v0.10.0-pre.4 #474

Merged

tarcieri added a commit that referenced this pull request Feb 14, 2025

v0.10.0-pre.4 (#474)

d7fa156

Notably includes #394 which migrates to `crypto-bigint`

pallaswept mentioned this pull request Feb 17, 2025

RUSTSEC-2023-0071: Marvin Attack: potential key recovery through timing sidechannels nresare/pam-ssh-agent#23

Open

fjarri mentioned this pull request Mar 5, 2025

Slowdown after switch to crypto-bigint #490

Open

noverby mentioned this pull request Apr 3, 2025

Is there a plan to fix Marvin Attack? #503

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: switch from num-bigint-dig to crypto-bigint #394

feat: switch from num-bigint-dig to crypto-bigint #394

dignifiedquire commented Nov 29, 2023 •

edited

Loading

tarcieri left a comment

dignifiedquire commented Jan 30, 2025

tarcieri Feb 1, 2025

dignifiedquire Feb 12, 2025

dignifiedquire Feb 13, 2025

fjarri Feb 13, 2025

fjarri Feb 13, 2025

tarcieri Feb 1, 2025

tarcieri Feb 1, 2025

tarcieri left a comment

tarcieri commented Feb 12, 2025

fjarri commented Feb 12, 2025

fjarri commented Feb 12, 2025

dignifiedquire commented Feb 12, 2025

dignifiedquire commented Feb 13, 2025

		pub fn random<R: CryptoRngCore + ?Sized>(rng: &mut R, bit_size: usize) -> Result<Self> {
		pub fn random<R: CryptoRngCore>(rng: &mut R, bit_size: usize) -> Result<Self> {

feat: switch from num-bigint-dig to crypto-bigint #394

feat: switch from num-bigint-dig to crypto-bigint #394

Conversation

dignifiedquire commented Nov 29, 2023 • edited Loading

TODOs

tarcieri left a comment

Choose a reason for hiding this comment

dignifiedquire commented Jan 30, 2025

tarcieri Feb 1, 2025

Choose a reason for hiding this comment

dignifiedquire Feb 12, 2025

Choose a reason for hiding this comment

dignifiedquire Feb 13, 2025

Choose a reason for hiding this comment

fjarri Feb 13, 2025

Choose a reason for hiding this comment

fjarri Feb 13, 2025

Choose a reason for hiding this comment

tarcieri Feb 1, 2025

Choose a reason for hiding this comment

tarcieri Feb 1, 2025

Choose a reason for hiding this comment

tarcieri left a comment

Choose a reason for hiding this comment

tarcieri commented Feb 12, 2025

fjarri commented Feb 12, 2025

fjarri commented Feb 12, 2025

dignifiedquire commented Feb 12, 2025

dignifiedquire commented Feb 13, 2025

dignifiedquire commented Nov 29, 2023 •

edited

Loading