Fix an overflow in Streebog causing panic or incorrect output #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the
update_sigma
function of Streebog.For example for the input consisting of 96 bytes of 255 (0xFF), current crate either panics:
Or produces an incorrect output:
Compare output with OpenSSL using the GOST engine:
Due to poor specification and missing KATs a number of other impls have run into similar issues
gpg/libgcrypt@da6cd4f