Add test for bare PING-PONG protocol over TLS handle #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tarcieri
approved these changes
Apr 19, 2024
|
Hmm, this broke the build on https://github.com/RustCrypto/rustls-rustcrypto/actions/runs/8755797614/job/24030745531
Certs either need to be generated on-the-fly so this doesn't happen, or configured with an expiration date far enough in the future it doesn't cause a (frequent) problem |
tarcieri
added a commit
that referenced
this pull request
Apr 24, 2024
This reverts commit 9d86cdb. These tests aren't working because the certificate they use is expired. It either needs to be longer-lived or generated automatically as part of the test suite to ensure it isn't expired.
tarcieri
added a commit
that referenced
this pull request
Apr 24, 2024
|
Reverted in #63 due to the cert expiry issue |
pinkforest
added a commit
to pinkforest/rustls-rustcrypto
that referenced
this pull request
Apr 24, 2024
…ypto#55)" (RustCrypto#63) This reverts commit 3c8d21d.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing against OpenSSL server with rustls-rustcrypto client
Perhaps I should organise some of this stuff as I wrote this quickly into self-contained thingy with minimal deps