rfc6979: decouple from crypto-bigint
#639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
rfc6979/decouple-from-crypto-bigint
branch
from
875b4d5 to
39296b2
Compare
The previous approach complicates supporting ECDSA with `FieldSize` which is different from `C::Uint::ByteSize`. The new implementation eliminates `crypto-bigint` as a dependency and makes the API entirely byte-oriented. This is a simpler approach which also eliminates some previous trait bounds on the generic ECDSA implementation.
tarcieri
force-pushed
the
rfc6979/decouple-from-crypto-bigint
branch
from
39296b2 to
5cdea51
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach complicates supporting ECDSA with
FieldSizewhich is different fromC::Uint::ByteSize.The new implementation eliminates
crypto-bigintas a dependency and makes the API entirely byte-oriented.This is a simpler approach which also eliminates some previous trait bounds on the generic ECDSA implementation.