ml-dsa: encode private key #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/ml-dsa/encode-private-key
branch
5 times, most recently
from
5d051e1 to
75af08e
Compare
baloo
force-pushed
the
baloo/ml-dsa/encode-private-key
branch
2 times, most recently
from
0830445 to
81d8d33
Compare
|
One more rebase and I think this is good to go |
|
Yeah I’ll do that in 2-3h when I get back home. |
This ensure the keypair can only be constructed from a seed.
baloo
force-pushed
the
baloo/ml-dsa/encode-private-key
branch
from
81d8d33 to
79ef8f1
Compare
tarcieri
approved these changes
Jan 26, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #891
This reworks the
ml_dsa::KeyPairto keep the seed along with theSigningKeywhich allows to serialize the private key to the pkcs8 format after that.