[WIP] cpubits: initial crate #826
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, what is this (unrelated) failure in https://github.com/RustCrypto/utils/actions/runs/3868175503/jobs/6593444420#step:6:13 Also this in https://github.com/RustCrypto/utils/actions/runs/3868175523/jobs/6593445047#step:7:13 |
tarcieri
force-pushed
the
cpubits
branch
2 times, most recently
from
0796d95 to
916240a
Compare
As discussed in #824, adds a crate with the intent of it providing heuristics for selecting whether 32-bit or 64-bit backends have optimal codegen for a given target, with optional overrides. The intended use of this crate is in `build-dependencies`, where it can emit a `cfg` attribute (e.g. `--cfg cpubits="64"`) if one hasn't been explicitly specified already, and all gating on 32-bit vs 64-bit backends can simply use the `cfg` attribute.
|
@tarcieri |
|
Yes |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #824, adds a crate with the intent of it providing heuristics for selecting whether 32-bit or 64-bit backends have optimal codegen for a given target, with optional overrides.
The intended use of this crate is in
build-dependencies, where it can emit acfgattribute (e.g.--cfg cpubits="64") if one hasn't been explicitly specified already, and all gating on 32-bit vs 64-bit backends can simply use thecfgattribute.