Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use npm ci in the build script so package.lock cannot get updated there #619

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Use npm ci in the build script so package.lock cannot get updated there #619

merged 2 commits into from
Jun 28, 2024

Conversation

Larocceau
Copy link
Contributor

addresses #618

  • NPM ci only installs packages according to package.json and package.lock, failing if they don't line up. CI is faster and will prevent unexpected changes to package.lock until the developer explicitly uses NPM install

mattgallagher92
mattgallagher92 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@mattgallagher92 mattgallagher92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

Let's just get at least one more person to confirm that they're happy with the intention of the change before merging this in

@Larocceau
Copy link
Contributor Author

install seems to be quicker than ci 🤯. Let's check again?

@Larocceau Larocceau marked this pull request as draft June 21, 2024 16:23
@jwthomson jwthomson self-requested a review June 28, 2024 12:10
@Larocceau Larocceau marked this pull request as ready for review June 28, 2024 12:11
@Larocceau Larocceau merged commit 91ab66b into master Jun 28, 2024
1 check was pending
@jwthomson jwthomson deleted the npm-ci-instead-of-install branch June 28, 2024 12:24
@jwthomson jwthomson mentioned this pull request Jun 28, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mattgallagher92 mattgallagher92 mattgallagher92 approved these changes

@jwthomson jwthomson jwthomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Larocceau @jwthomson @mattgallagher92