Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change the api to return full TODO list after adding todo #624

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Larocceau
Copy link
Contributor

@Larocceau Larocceau commented Aug 9, 2024

Addresses #615 in a more conclusive manner:

  • Test failed because it lacked loading the initial data; because the added todo was mapped into a RemoteData type, data disappeared quietly when that RemoteData object was not in the Finished state yet.
  • Solution: Make the API return the full todo list, so you can fully replace the todo list after an update

@Larocceau Larocceau merged commit dc30e03 into master Aug 16, 2024
1 check passed
@Larocceau Larocceau deleted the return-full-todo-list branch August 16, 2024 08:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants