Fix #487. Enable strict check on in_array method

SAML-Toolkits · Sep 6, 2021 · 107757b · 107757b
1 parent 6f4cf30
commit 107757b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Saml2/Response.php b/src/Saml2/Response.php
@@ -814,7 +814,7 @@ private function _getAttributesByKeyName($keyName = "Name")
                 continue;
             }
             $attributeKeyName = $attributeKeyNode->nodeValue;
-            if (in_array($attributeKeyName, array_keys($attributes))) {
+            if (in_array($attributeKeyName, array_keys($attributes), true)) {
                 if (!$allowRepeatAttributeName) {
                     throw new ValidationError(
                         "Found an Attribute element with duplicated ".$keyName,
@@ -830,7 +830,7 @@ private function _getAttributesByKeyName($keyName = "Name")
                 }
             }
 
-            if (in_array($attributeKeyName, array_keys($attributes))) {
+            if (in_array($attributeKeyName, array_keys($attributes), true)) {
                 $attributes[$attributeKeyName] = array_merge($attributes[$attributeKeyName], $attributeValues);
             } else {
                 $attributes[$attributeKeyName] = $attributeValues;