Add artifact binding for ACS #237
Conversation
I used 1 artifactResolutionService (the first) and it was parsed from the metadata file. However, in the metadata file I am using, the same URL is used, with two different indexes. Since the wrong index was returned, this caused errors. Another implementation would be to just ignore the index/url returned in the SAML artifact.
to do ArtifactResolve/Artifact Binding.
|
I will need time to review this. I have not many requirements related to Artifact binding, but I will consider adding this. In a fast review, I see you made some improvements in parts of the code, so maybe a start is to add them to make your code compatible... later let's see if add this piece of code or see if we can make this available via a plugin or something. My first goal is to keep the toolkit simple so I always have a battle between functionality and UX. |
|
@pitbulk That direction make sense to me. I'm hoping to have some time next week to split out these changes. |
|
@pitbulk I've been following up some of our forks to check if they are still needed and if the changes can be/are contributed back to upstream. While doing some, I stumbled on python3-saml and three pull requests by flupzor from our fork. Unfortunately flupzor no longer works with us, so I can't ask directly about the state of those PRs, but I was wondering if you could answer these high level questions:
Thanks in advance for any replies! |
|
We'd love to see the Artifact Binding being added to this repo! For the same reason @flupzor made this merge request. Hopefully you'll be able to successfully merge this. @sergei-maertens |
pitbulk
force-pushed
the
master
branch
2 times, most recently
from
4fa3934 to
acef8eb
Compare
|
@maintainers - now that this library is transferred, can you give us an indication on how viable the PRs authored by @flupzor are to be merged? Or let us know what is needed to merge these - we'd really like to replace our fork again with the upstream version :) |
|
@pitbulk sorry to ping you - is the wontfix label a final conclusion? My above comment was never addressed it seems. |
We've used the wonderful python3-saml code to create an implementation for
two dutch government services (DigiD en eHerkenning). This meant that we had to make various changes
to python3-saml code. The biggest being the Artifact Binding for the ACS.
This PR adds support for the Artifact Binding for the ACS for python3-saml. I've tried as much as I could to keep
the coding style which was used in this project.