Skip to content

Commit

Permalink
Merge pull request #580 from onelogin/replace_method__exists
Browse files Browse the repository at this point in the history
Fix #573. Replace method_exists? by respond_to?
  • Loading branch information
pitbulk committed Apr 5, 2021
2 parents 3ed4da3 + 2f95ee7 commit 79fc1d7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# RubySaml Changelog

### 1.12.1 (Apr 05, 2022)
* Fix XPath typo incompatible with Rexml 3.2.5
* Refactor GCM support

### 1.12.0 (Feb 18, 2021)
* Support AES-128-GCM, AES-192-GCM, and AES-256-GCM encryptions
* Parse & return SLO ResponseLocation in IDPMetadataParser & Settings
Expand Down
2 changes: 1 addition & 1 deletion lib/onelogin/ruby-saml/attributes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def ==(other)
def fetch(name)
attributes.each_key do |attribute_key|
if name.is_a?(Regexp)
if name.method_exists? :match?
if name.respond_to? :match?
return self[attribute_key] if name.match?(attribute_key)
else
return self[attribute_key] if name.match(attribute_key)
Expand Down
2 changes: 1 addition & 1 deletion lib/onelogin/ruby-saml/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module OneLogin
module RubySaml
VERSION = '1.12.0'
VERSION = '1.12.1'
end
end

2 comments on commit 79fc1d7

@mathieujobin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This release has 2022 in the title and changelog, but it was done in 2021, right?

@pitbulk
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so

Please # to comment.